Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Progress): NaN not returned when max and value are zero #6867

Merged
merged 2 commits into from Feb 7, 2022
Merged

fix(Progress): NaN not returned when max and value are zero #6867

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ef16cb
fix(Progress): NaN not returned when max and value are zero
thatblindgeye Jan 28, 2022
c11c595
Update scaledValue calculation
thatblindgeye Feb 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-core/src/components/Progress/Progress.tsx
View file
Open in desktop
Expand Up @@ -113,7 +113,7 @@ export class Progress extends React.Component<ProgressProps> {
);
}

const scaledValue = Math.min(100, Math.max(0, Math.floor(((value - min) / (max - min)) * 100)));
const scaledValue = Math.min(100, Math.max(0, Math.floor(((value - min) / (max - min)) * 100))) || 0;
return (
<div
{...props}
Expand Down