-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(table): 6776 table example with overflow menu action #6979
docs(table): 6776 table example with overflow menu action #6979
Conversation
Preview: https://patternfly-react-pr-6979.surge.sh A11y report: https://patternfly-react-pr-6979-a11y.surge.sh |
b5a4a97
to
9f31ce9
Compare
This is looking good! |
@nicolethoen This looks like a workspace issue to me. Several intermediary content wrappers are causing odd issues, more detail coming soon... |
@gitdallas I opened a PR to fix the workspace issue in Org. |
packages/react-table/src/components/TableComposable/examples/ComposableTableActionsOverflow.tsx
Outdated
Show resolved
Hide resolved
squash me squash me squash me
9f31ce9
to
2d0b545
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LPTM! 🎉
@@ -167,6 +167,13 @@ To make a cell an action cell, render an `ActionsColumn` component inside a row' | |||
```ts file="ComposableTableActions.tsx" | |||
``` | |||
|
|||
### Composable: Actions Overflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit. This and should be sentence case.
What: Closes #6776