Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(table): 6776 table example with overflow menu action #6979

Merged

Conversation

gitdallas
Copy link
Contributor

What: Closes #6776

@patternfly-build
Copy link
Contributor

patternfly-build commented Feb 25, 2022

@nicolethoen
Copy link
Contributor

This is looking good!
Question for @mattnolting - it looks like at smaller widths, the width of the table is too wide for me to be able to see or scroll horizontally to the overflow menu. Should we update the width of the table examples at smaller views? If so, how?

@mattnolting
Copy link
Contributor

mattnolting commented Mar 1, 2022

Question for @mattnolting - it looks like at smaller widths, the width of the table is too wide for me to be able to see or scroll horizontally to the overflow menu. Should we update the width of the table examples at smaller views? If so, how?

@nicolethoen This looks like a workspace issue to me. Several intermediary content wrappers are causing odd issues, more detail coming soon...

@nicolethoen
Copy link
Contributor

nicolethoen commented Mar 3, 2022

@gitdallas I opened a PR to fix the workspace issue in Org.
patternfly/patternfly-org#2864

@gitdallas gitdallas force-pushed the feat/6776-overflow-action-table-example branch from 9f31ce9 to 2d0b545 Compare March 3, 2022 21:23
Copy link
Contributor

@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LPTM! 🎉

@kmcfaul kmcfaul merged commit 3a1eb49 into patternfly:main Mar 3, 2022
@nicolethoen nicolethoen requested a review from kmcfaul March 4, 2022 14:32
@@ -167,6 +167,13 @@ To make a cell an action cell, render an `ActionsColumn` component inside a row'
```ts file="ComposableTableActions.tsx"
```

### Composable: Actions Overflow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit. This and should be sentence case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Table demo - add example using overflow-menu instead of dropdown + extra buttons
6 participants