chore: fix various a11y violations in examples (3) #7619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-7619.surge.sh A11y report: https://patternfly-react-pr-7619-a11y.surge.sh |
| @@ -76,7 +76,7 @@ DualListSelectorControlsWrapperBase.displayName = 'DualListSelectorControlsWrapp | |||
|
|
|||
| export const DualListSelectorControlsWrapper = React.forwardRef( | |||
| (props: DualListSelectorControlsWrapperProps, ref: React.Ref<HTMLDivElement>) => ( | |||
| <DualListSelectorControlsWrapperBase innerRef={ref as React.MutableRefObject<any>} {...props} /> | |||
| <DualListSelectorControlsWrapperBase innerRef={ref as React.MutableRefObject<any>} {...props} role="region" /> | |||
There was a problem hiding this comment.
For the role, would "region" or "group" be better in this context? Currently the selector controls appear in VO's rotor under "landmarks", and wasn't sure if that may have been part of the intent or not.
There was a problem hiding this comment.
ooo good thought
thatblindgeye
approved these changes
Jul 6, 2022
tlabaj
reviewed
Jul 6, 2022
| @@ -76,7 +76,7 @@ DualListSelectorControlsWrapperBase.displayName = 'DualListSelectorControlsWrapp | |||
|
|
|||
| export const DualListSelectorControlsWrapper = React.forwardRef( | |||
| (props: DualListSelectorControlsWrapperProps, ref: React.Ref<HTMLDivElement>) => ( | |||
| <DualListSelectorControlsWrapperBase innerRef={ref as React.MutableRefObject<any>} {...props} /> | |||
| <DualListSelectorControlsWrapperBase innerRef={ref as React.MutableRefObject<any>} {...props} role="group" /> | |||
There was a problem hiding this comment.
Are spreading props before the role here incase someone tries to override it?
There was a problem hiding this comment.
I don't think so - I will spread props at the end
dlabrecq
approved these changes
Jul 7, 2022
jessiehuff
approved these changes
Jul 7, 2022
tlabaj
approved these changes
Jul 8, 2022
jenny-s51
pushed a commit
to jenny-s51/patternfly-react
that referenced
this pull request
Jul 26, 2022
* chore: fix various a11y violations in examples (3) * clean up tests * fix context selector tests * fix broken props table * change controls' role from region to group * update snapshots * spread props at end of duallistselectorcontrolswrapperbase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #7610
few notes:
idto the unit test cases so they would be the same across snapshots. Also, the items inside context selector menus did not have therole='menuitem'so I added it.aria-multiselectable,aria-labelledby,aria-activedescendant, androle=tree|listboxshould only be applied when they have the requisite valid children with valid roles. In the case of empty lists, they should not have those roles (according to the axe tests).