Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charts - remove theme variant for v5 #8590

Merged
merged 1 commit into from Feb 8, 2023
Merged

Charts - remove theme variant for v5 #8590

merged 1 commit into from Feb 8, 2023

Conversation

dlabrecq
Copy link
Member

@dlabrecq dlabrecq commented Jan 25, 2023 •
edited

There are deprecated theme variant properties and unused color themes to remove for v5. Anything related to the theme variant is dead code.

#8532

@patternfly-build
Copy link
Contributor

patternfly-build commented Jan 25, 2023 •
edited

Preview: https://patternfly-react-pr-8590.surge.sh

A11y report: https://patternfly-react-pr-8590-a11y.surge.sh

@dlabrecq dlabrecq force-pushed the v5-8532-deprecations branch 2 times, most recently from 6765a2f to 86b992c Compare January 25, 2023 15:58
@dlabrecq dlabrecq mentioned this pull request Jan 26, 2023
Closed
@dlabrecq dlabrecq added the PF5 label Jan 26, 2023
@dlabrecq dlabrecq requested a review from tlabaj January 27, 2023 17:18
nicolethoen
nicolethoen reviewed Jan 27, 2023
View reviewed changes
Copy link
Contributor

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you open a code mod issue that lists:

  • all the components + props which have been removed (the code mods should clean those up)
  • all the functions made private (our code mods should likely warn them that the functions are now private)

@dlabrecq
Copy link
Member Author

The codemod issue is patternfly/pf-codemods#232

@tlabaj tlabaj merged commit 12e1c47 into patternfly:v5 Feb 8, 2023
@dlabrecq dlabrecq deleted the v5-8532-deprecations branch February 15, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolethoen nicolethoen nicolethoen approved these changes

@tlabaj tlabaj tlabaj approved these changes

Assignees
No one assigned
Labels
PF5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dlabrecq @patternfly-build @nicolethoen @tlabaj