Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charts - remove theme variant for v5 #8532

Closed
dlabrecq opened this issue Jan 11, 2023 · 0 comments
Closed

Charts - remove theme variant for v5 #8532

dlabrecq opened this issue Jan 11, 2023 · 0 comments
Assignees
@dlabrecq
Labels
Breaking change 💥 this change requires a major release and has API changes. PF5

Comments

@dlabrecq
Copy link
Member

dlabrecq commented Jan 11, 2023 •
edited
Loading

There are deprecated theme variant properties and unused color themes to remove for v5.

Note: We intended the charts to have its own light & dark themes, but this functionality was replaced by PatternFly core's dark theme support. At that time, props were marked @deprecated.

That said, anything related to the theme variant is dead code.

  • getCustomTheme (chart-theme.ts)
  • ChartThemeVariant (ChartTheme.ts)
  • ChartThemeVariantInterface (ChartTheme.ts)
  • themeVariant

We should also remove unused themes such as DarkMultiColorOrderedTheme.
And rename LightMultiColorOrderedTheme themes as MultiColorOrderedTheme.
@dlabrecq dlabrecq added Breaking change 💥 this change requires a major release and has API changes. bug labels Jan 11, 2023
@dlabrecq dlabrecq self-assigned this Jan 11, 2023
@github-project-automation github-project-automation bot moved this to Not started in PatternFly Issues Jan 11, 2023
@dlabrecq dlabrecq changed the title Charts - Deprecations Charts - deprecations Jan 12, 2023
@dlabrecq dlabrecq changed the title Charts - deprecations Charts - remove deprecations Jan 12, 2023
@dlabrecq dlabrecq changed the title Charts - remove deprecations Charts - remove deprecated theme variant Jan 24, 2023
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Jan 25, 2023
@dlabrecq
feat(charts): remove deprecated theme variant code
8f8be6b 
patternfly#8532
@dlabrecq dlabrecq changed the title Charts - remove deprecated theme variant Charts - remove theme variant Jan 25, 2023
@dlabrecq dlabrecq mentioned this issue Jan 25, 2023
Merged
dlabrecq added a commit to dlabrecq/pf-codemods that referenced this issue Jan 25, 2023
@dlabrecq
feat(charts): remove deprecated theme variant code
31e0be0 
patternfly/patternfly-react#8532
@dlabrecq dlabrecq mentioned this issue Jan 25, 2023
Merged
dlabrecq added a commit to dlabrecq/pf-codemods that referenced this issue Jan 25, 2023
@dlabrecq
feat(charts): remove deprecated theme variant code
2a66904 
patternfly/patternfly-react#8532
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Jan 25, 2023
@dlabrecq
feat(charts): remove deprecated theme variant code
6765a2f 
patternfly#8532
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Jan 25, 2023
@dlabrecq
feat(charts): remove deprecated theme variant code
86b992c 
patternfly#8532
@dlabrecq dlabrecq changed the title Charts - remove theme variant Charts v5 - remove theme variant for v5 Jan 25, 2023
@dlabrecq dlabrecq changed the title Charts v5 - remove theme variant for v5 Charts - remove theme variant for v5 Jan 25, 2023
dlabrecq added a commit to dlabrecq/pf-codemods that referenced this issue Jan 25, 2023
@dlabrecq
feat(charts): remove deprecated theme variant code
ab2ad62 
patternfly/patternfly-react#8532
dlabrecq added a commit to dlabrecq/pf-codemods that referenced this issue Jan 25, 2023
@dlabrecq
feat(charts): remove deprecated theme variant code
5b571b8 
patternfly/patternfly-react#8532
dlabrecq added a commit to dlabrecq/pf-codemods that referenced this issue Jan 25, 2023
@dlabrecq
feat(charts): remove deprecated theme variant code
f603593 
patternfly/patternfly-react#8532
gitdallas pushed a commit to patternfly/pf-codemods that referenced this issue Jan 28, 2023
@dlabrecq
feat(charts): remove deprecated theme variant code (#227)
6348aa3 
patternfly/patternfly-react#8532
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Jan 28, 2023
@dlabrecq
feat(charts): remove deprecated theme variant code
f371c74 
patternfly#8532
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Jan 28, 2023
@dlabrecq
feat(charts): remove deprecated theme variant code
57ff7da 
patternfly#8532
tlabaj pushed a commit that referenced this issue Feb 8, 2023
@dlabrecq
feat(charts): remove deprecated theme variant code (#8590)
12e1c47 
#8532
@github-project-automation github-project-automation bot moved this from Not started to Done in PatternFly Issues Feb 13, 2023
@nicolethoen nicolethoen added the PF5 label Mar 7, 2023
@nicolethoen nicolethoen moved this to Done in PatternFly 5 Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dlabrecq dlabrecq

Labels
Breaking change 💥 this change requires a major release and has API changes. PF5
Projects
PatternFly 5
Status: Done
PatternFly Issues
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dlabrecq @nicolethoen