chore(DatePicker): updated popover to append inline #8636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-8636.surge.sh A11y report: https://patternfly-react-pr-8636-a11y.surge.sh |
gitdallas
approved these changes
Jan 31, 2023
thatblindgeye
approved these changes
Feb 2, 2023
kmcfaul
approved these changes
Feb 6, 2023
gitdallas
requested changes
Feb 8, 2023
| @@ -22,7 +22,7 @@ export interface DatePickerProps | |||
| * menuAppendTo={() => document.body}; | |||
| * menuAppendTo={document.getElementById('target')} | |||
| */ | |||
| appendTo?: HTMLElement | ((ref?: HTMLElement) => HTMLElement) | 'parent'; | |||
| appendTo?: HTMLElement | ((ref?: HTMLElement) => HTMLElement) | 'inline'; | |||
There was a problem hiding this comment.
need to change the jsdoc default as well
There was a problem hiding this comment.
Good catch!
wise-king-sullyman
force-pushed
the
date-picker-append-inline
branch
from
22fb92d
to
b6213c6
Compare
thatblindgeye
approved these changes
Feb 10, 2023
wise-king-sullyman
force-pushed
the
date-picker-append-inline
branch
from
b6213c6
to
5458826
Compare
gitdallas
approved these changes
Feb 10, 2023
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #8596
Additional issues:
Convenience link: https://patternfly-react-pr-8636.surge.sh/components/date-picker#basic