-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(DatePicker): updated popover to append inline #8636
chore(DatePicker): updated popover to append inline #8636
Conversation
Preview: https://patternfly-react-pr-8636.surge.sh A11y report: https://patternfly-react-pr-8636-a11y.surge.sh |
@@ -22,7 +22,7 @@ export interface DatePickerProps | |||
* menuAppendTo={() => document.body}; | |||
* menuAppendTo={document.getElementById('target')} | |||
*/ | |||
appendTo?: HTMLElement | ((ref?: HTMLElement) => HTMLElement) | 'parent'; | |||
appendTo?: HTMLElement | ((ref?: HTMLElement) => HTMLElement) | 'inline'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to change the jsdoc default as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
22fb92d
to
b6213c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just needs a quick rebase
b6213c6
to
5458826
Compare
Your changes have been released in:
Thanks for your contribution! 🎉 |
What: Closes #8596
Additional issues:
Convenience link: https://patternfly-react-pr-8636.surge.sh/components/date-picker#basic