-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(TextInput): swap onChange params in demos #9196
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview: https://patternfly-react-pr-9196.surge.sh A11y report: https://patternfly-react-pr-9196-a11y.surge.sh |
jenny-s51
requested changes
May 26, 2023
MariaAga
force-pushed
the
text-input-onchange-left
branch
from
May 26, 2023 14:37
4bab5b1
to
4e43c27
Compare
tlabaj
approved these changes
May 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
jenny-s51
approved these changes
May 30, 2023
Your changes have been released in:
Thanks for your contribution! 🎉 |
nicolethoen
pushed a commit
to Kells512/patternfly-react
that referenced
this pull request
Sep 1, 2023
dgdavid
added a commit
to agama-project/agama
that referenced
this pull request
Sep 12, 2023
Patternfly 5 has swapped the #onChange params of quite a lot components for putting the event first. This is more aligned with the native HTML change event, https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/change_event. This PR, based on changes proposed by https://github.com/patternfly/pf-codemods, update Agama components using below PF elements * FormSelect - patternfly/patternfly-react#8998 * Switch - patternfly/patternfly-react#9037 * TextInput - patternfly/patternfly-react#9064 - patternfly/patternfly-react#9196
dgdavid
added a commit
to agama-project/agama
that referenced
this pull request
Sep 12, 2023
Patternfly 5 has swapped the #onChange params of quite a lot components for putting the event first. This is more aligned with the native HTML change event, https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/change_event. This PR, based on changes proposed by https://github.com/patternfly/pf-codemods, update Agama components using below PF elements * FormSelect - patternfly/patternfly-react#8998 * Switch - patternfly/patternfly-react#9037 * TextInput - patternfly/patternfly-react#9064 - patternfly/patternfly-react#9196
dgdavid
added a commit
to agama-project/agama
that referenced
this pull request
Sep 14, 2023
Patternfly 5 has swapped the #onChange params of quite a lot components for putting the event first. This is more aligned with the native HTML change event, https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/change_event. This PR, based on changes proposed by https://github.com/patternfly/pf-codemods, update Agama components using below PF elements * FormSelect - patternfly/patternfly-react#8998 * Switch - patternfly/patternfly-react#9037 * TextInput - patternfly/patternfly-react#9064 - patternfly/patternfly-react#9196
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #9192
a few function args weren't swapped in #9064