Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demo_streams.pkl does not include necessary rfdata stats #12

Closed
jaredbryan881 opened this issue Aug 20, 2020 · 2 comments
Closed

demo_streams.pkl does not include necessary rfdata stats #12

jaredbryan881 opened this issue Aug 20, 2020 · 2 comments

Comments

@jaredbryan881
Copy link
Contributor

When the HkStack and Harmonics classes are initialized with 'demo', they load receiver functions from demo_streams.pkl. The receiver functions in demo_streams.pkl were created (dc0eb66) before the _add_rfstats nested function of rfdata's to_stream method included taxis (and other stats like phase, cc, etc.) (0fe006e). The following lines throw an AttributeError because taxis does not exist.

RfPy/rfpy/hk.py

Line 107 in 4913104

if rfV1[0].stats.taxis[0] < 0.:

if radialRF[0].stats.taxis[0]<0.:

I think demo_streams.pkl just needs to be recreated to include these stats.

@paudetseis
Copy link
Owner

Thanks @jaredbryan881 for catching this - indeed the code has changed since the demo data were created and they have not been updated since then. This should be an easy fix.

@jaredbryan881
Copy link
Contributor Author

This is fixed as of b0aa1d0! Closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants