Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add in log feature #44

Closed
wants to merge 4 commits into from

Conversation

TRex22
Copy link

@TRex22 TRex22 commented Sep 10, 2019

What does this PR do?

  • Adds in a method to log to the console above the progress_bar

Before:

image

Using the #log method

image

@TRex22
Copy link
Author

TRex22 commented Sep 10, 2019

Sorry these took me a while to send through. Work has been crazy busy

@TRex22
Copy link
Author

TRex22 commented Sep 10, 2019

I haven't set a minor version release here ... Im thinking I should for each PR I release but Ill defer to you, @paul

@TRex22
Copy link
Author

TRex22 commented Sep 10, 2019

Also it looks like one of the selected CI versions is no longer available

Copy link
Owner

@paul paul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been wanting something like this for awhile, but never had the time to do it, so thanks for tackling it! Just a few code quality comments.

lib/progress_bar.rb Show resolved Hide resolved
spec/log_spec.rb Outdated Show resolved Hide resolved
spec/log_spec.rb Outdated Show resolved Hide resolved
@TRex22 TRex22 requested a review from paul September 11, 2019 15:01
@TRex22
Copy link
Author

TRex22 commented Sep 11, 2019

@paul did I resolve your concerns with this PR?

@paul
Copy link
Owner

paul commented Sep 12, 2019

@TRex22 hey, sorry for the delay. I've got a busy week and weekend ahead, but I'm going to try and get to these PRs as soon as I can. Thanks for opening them!

@TRex22
Copy link
Author

TRex22 commented Sep 13, 2019

Hey @paul no worries. Thanks for taking the time to review my work. The past week was very busy for me so I know how it feels

@BenjiWiebe
Copy link

I would love for this be included. This is the exact feature I'm looking for ATM. Thanks!

@TRex22
Copy link
Author

TRex22 commented Aug 24, 2020

Ive been meaning to pick this up again ... just had a lot on my plate. Ill try to put some time aside to finish these features

@paul
Copy link
Owner

paul commented Aug 27, 2020

I've been crazy busy, too. And I even needed this feature last week 😄

@paul
Copy link
Owner

paul commented Aug 30, 2020

Closing in favor of #56

@paul paul closed this Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants