-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: add in log feature #44
Conversation
Sorry these took me a while to send through. Work has been crazy busy |
I haven't set a minor version release here ... Im thinking I should for each PR I release but Ill defer to you, @paul |
Also it looks like one of the selected CI versions is no longer available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been wanting something like this for awhile, but never had the time to do it, so thanks for tackling it! Just a few code quality comments.
@paul did I resolve your concerns with this PR? |
@TRex22 hey, sorry for the delay. I've got a busy week and weekend ahead, but I'm going to try and get to these PRs as soon as I can. Thanks for opening them! |
Hey @paul no worries. Thanks for taking the time to review my work. The past week was very busy for me so I know how it feels |
I would love for this be included. This is the exact feature I'm looking for ATM. Thanks! |
Ive been meaning to pick this up again ... just had a lot on my plate. Ill try to put some time aside to finish these features |
I've been crazy busy, too. And I even needed this feature last week 😄 |
Closing in favor of #56 |
What does this PR do?
Before:
Using the
#log
method