-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds ProgressBar#puts #56
Conversation
@TRex22 @BenjiWiebe I'll probably merge and release this weekend, but I wanted to see if you had any thoughts before I do. |
Cool Ill look over now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Yeah looks good to me...
The reason I used log
and not puts
was around the fact that it does not behave exactly like puts
does. i.e. puts
prints given text and then a new line. Here it's kind of printing above the progress bar. More of a philosophical reason
@TRex22 The reason I chose |
Allows one to print log messages without interfering with the output of the ProgressBar.
I think the code is cleaner in these cases with concatentation
Is this going to get rolled up into a release? |
@ppkn I think I was waiting for feedback in the other PRs, then forgot all about it. I'll cut a new release today! |
@ppkn done, released 1.3.2: https://rubygems.org/gems/progress_bar |
Adds support to print messages without interfering with the output of the bar.
See README and
examples/printing_messages.rb
.