This repository has been archived by the owner on Apr 11, 2018. It is now read-only.
Date filter's N and w formatting characters where off by one #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added date-string translation ability and test cases
…tests happen before filters, errors are thrown.
|
Can you fix this to only include the relevant commits? Make a new branch |
|
Fixed in b97809c |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The formatting character 'w' started with sunday == -1 and N started with sunday == 0. The test case was itself testing for the wrong values. The simple fix attached.
EDIT: Hmm, I didn't realize that new commits will be added to the pull request automatically. Now, this pull request also has my changes to enable date string customization and a few Spanish language test cases.
I really must learn to use git better!