Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS SRV "target" names are compressed #66

Closed
bobstanden opened this issue Jun 21, 2024 · 2 comments
Closed

DNS SRV "target" names are compressed #66

bobstanden opened this issue Jun 21, 2024 · 2 comments

Comments

@bobstanden
Copy link

DNS SRV RR should not be compressed.

From RFC2782, page 3:

Target
The domain name of the target host. There MUST be one or more address records for this name, the name MUST NOT be an alias (in the sense of RFC 1034 or RFC 2181). Implementors are urged, but not required, to return the address record(s) in the Additional Data section. Unless and until permitted by future standards action, name compression is not to be used for this field.

The correction is at line 1457 of dns.py:
buffer.encode_name_nocompress(self.target)

and, for completion, to comment at line 297 of label.py:
(needed for RRSIG, SRV)

@bobstanden
Copy link
Author

I have raised this issue also in dnslib3

@paulc
Copy link
Owner

paulc commented Jul 8, 2024

Fixed in 0.9.25 - thanks.

@paulc paulc closed this as completed Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants