-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No regex capture while parsing search output for ... #6
Comments
Hi @jwest23, Thanks for the detailed report! I can indeed easily reproduce the issue. Using
The search in itself therefore succeeds, but the version extraction then fails. Looking at the This should therefore be easy to fix: extending the capture group to be something in the likes of
I'll try this some time soon, most probably tomorrow night at the latest.
❤️ |
My "Expected Behavior" could use a little polish. Expected Behavior When encountering a version with a pre-alpha or build metadata extension such as cargo-nextest 0.9.62-a.2 or tokei 13.0.0-alpha.0 cargo-liner would:
This is similar to the behavior of cargo-update;
which is helpful when deciding how I want to proceed. Thank you again! cargo-liner has greatly improved the consistency of which tools are available to me in my various environments and saves me a ton of time! |
Yes, I see what you mean. Thanks for clarifying. However, you should know that the versions passed onto calls to ❯ cargo install --version '*' cargo-nextest
Updating crates.io index
Installing cargo-nextest v0.9.61 What you want should therefore already be done: only the stable version is used. The versions that you see on the standard output are only coming from the result of calls to It therefore seems to me the two issues are separate: could you move that into another issue then? Also please keep bugs and feature requests separate as well, it helps my understanding of things. |
@jwest23 The issue I just opened should cover what I found concerning this from the point of bugs. Feel free to open another bug or feature request issue if it does not cover exactly what you had in mind, however. |
…utput extraction `semver::Version` still applies a stricter parsing after. Signed-off-by: Paul Mabileau <paulmabileau@hotmail.fr>
The commit I just pushed should fix the direct issue:
were installed instead of the pre-release versions available. You should thus be able to use that commit by installing from source with I am therefore going to close this, but if it actually does not work for you, feel free to re-open it. |
Would it be possible to make this fix available in a release version now? We also ran into this issue in our CI pipeline. |
Fix released as part of v0.4.2. |
Signed-off-by: Paul Mabileau <paulmabileau@hotmail.fr>
Description
Running
cargo liner
when the liner.toml contains references to certain packages causes it to error out:The package versions are currently:
cargo-nextest: 0.9.62-a.2
tokei: 13.0.0-alpha.0
Expected behavior
Installation of cargo-nextest and tokei.
To Reproduce
cargo liner
Output
Context
Additional information
Thanks for cargo-liner and for looking into this!
The text was updated successfully, but these errors were encountered: