Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new build env on Travis #59

Merged
merged 1 commit into from
Nov 20, 2014
Merged

Use the new build env on Travis #59

merged 1 commit into from
Nov 20, 2014

Conversation

joshk
Copy link
Contributor

@joshk joshk commented Nov 20, 2014

trust me, its fantastic !

trust me, its fantastic !
@krasnoukhov
Copy link
Collaborator

Thanks. What's the difference? I see sudo: false, what's that?

@joshk
Copy link
Contributor Author

joshk commented Nov 20, 2014

hmmm, why aren't Pull Requests building?

@joshk
Copy link
Contributor Author

joshk commented Nov 20, 2014

sudo: false routes this to our new build env.

faster vms, more ram, more cpu, better network

like I said in the PR description, trust me :)

@krasnoukhov
Copy link
Collaborator

That's good question. I've asked Travis team about that some time ago. The thing is that this repo doesn't have its original author logged in (I mean @pauldix), so it just does not work. I've asked him on Twitter to do that, but he didn't replied, so basically I can do nothing about that.

Thanks anyway!

krasnoukhov added a commit that referenced this pull request Nov 20, 2014
Use the new build env on Travis
@krasnoukhov krasnoukhov merged commit ea4feeb into pauldix:master Nov 20, 2014
@krasnoukhov
Copy link
Collaborator

You were right - total build time cut in half! What do I do with sudo thing when you roll out new env as default? Should I keep it?

@joshk
Copy link
Contributor Author

joshk commented Nov 20, 2014

yep, just keep it there, that is how we will route to the new setup :)

if you see a repo which doesn't need sudo, feel free to send them a PR with the sudo: false :)

@joshk
Copy link
Contributor Author

joshk commented Nov 20, 2014

Hmmmmmm, that is odd. I checked the logs and things seems fine.

I guess once you get him to log in again I can check if the hook we have is correct.

@krasnoukhov
Copy link
Collaborator

Thanks for looking into this. I've emailed @pauldix, let's see if he replies.

@pauldix
Copy link
Owner

pauldix commented Nov 23, 2014

Sorry for not being responsive. I never set up travis on this, so I'm not sure who has that account. Tell me what I need to do here.

@krasnoukhov
Copy link
Collaborator

Thanks @pauldix. Hey @joshk, so what do we do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants