Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix uninitialized class variable error when nokogiri is used as handler #60

Merged
merged 1 commit into from
Nov 20, 2014

Conversation

abrandoned
Copy link
Contributor

when nokogiri is chosen as the handler @@handler is uninitialized

@krasnoukhov
Copy link
Collaborator

Thanks. How do I reproduce that? There is some code below that sets the initial handler, which is supposed to set @@handler.

@abrandoned
Copy link
Contributor Author

if you allow it to use nokogiri on requiring sax-machine it will throw the exception

the code below does try to initialize it, but on access of a class instance variable it will raise the uninitialized class variable exception as the first access does not initialize it

krasnoukhov added a commit that referenced this pull request Nov 20, 2014
fix uninitialized class variable error when nokogiri is used as handler
@krasnoukhov krasnoukhov merged commit e3fc129 into pauldix:master Nov 20, 2014
@krasnoukhov
Copy link
Collaborator

Got it. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants