-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a more meaningful error message in case a tested site is too slow instead of "metric unavailable" #28
Comments
@rpkoller thanks, I faced the same issue measuring https://www.cnet.com/special-reports/jony-ive-talks-about-putting-the-apple-touch-on-the-macbook-pro/ too. @paulirish should we handle this case in scope of |
yeah. for both it would be helpful to do also @denar90, we probably should catch rejections coming from lighthouse and handle those. it's possible both cases woulda come in like that. |
@paulirish problem is those |
I've created ticket for Lighthouse. Will keep in touch with guys there. @rpkoller I reproduced this issue with @paulirish I found out where it's crashed - https://github.com/GoogleChrome/lighthouse/blob/a7648e7eeef7dce5641147f2bf75725a084e8937/lighthouse-core/audits/first-meaningful-paint.js#L148. |
Any update on this issue? I've come across it a couple of times aswell. |
@pedro93 we are waiting for resolving |
Seeing as this is merged I will close it. Feel free to re-open it something is missing. |
It is probably a naming issue. I've installed version 1.2.4 and ran into something i haven't seen yet afterwards. I occassionally get now that kind of errors on slower sites I test against:
But If i observe the Chrome window alongside it is actually painting something but i guess i am going past a certain time scope threshold benchmarking?! so pwmetric terminates the benchmark after a certain time? I wouldn't call it unavailable then but something like, took too long and aborted or provide some override to go until the bitter end? ;) cheers r.
The text was updated successfully, but these errors were encountered: