Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is the patched Meshtastic app still required? #47

Closed
a-f-G-U-C opened this issue Oct 11, 2020 · 3 comments
Closed

Is the patched Meshtastic app still required? #47

a-f-G-U-C opened this issue Oct 11, 2020 · 3 comments

Comments

@a-f-G-U-C
Copy link
Contributor

I noticed I've been accidentally running the plugin with the mainline Meshtastic-Android app with no apparent issues.

Is the requirement from the README (under "Build + Install Meshtastic") still relevant, or have the changes been merged into the mainline code in the meanwhile?
@paulmandal
Copy link
Owner

My PR: meshtastic/Meshtastic-Android#172 was merged about 2 weeks ago but I don't think they have done a release since then. Are you seeing an error in logcat about a Handler not being able to be created on a thread that has not called Looper.prepare()? Did you set the device up previously in the Meshtastic app?

@a-f-G-U-C
Copy link
Contributor Author

I was running a self-compiled APK, post Looper fix. This explains why it "just worked" :)

I suggest updating the README instructions to point to the meshtastic repo, which now includes your fix, along with a few other useful fixes and features not included in your fork.

@paulmandal
Copy link
Owner

Good call, updated the README here: #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulmandal @a-f-G-U-C