Fix unwatch and some sporadic test errors #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulmillr
added a commit
that referenced
this pull request
Sep 18, 2015
Fix unwatch and some sporadic test errors
|
What's the best way to get these changes. I used npm install chokidar to initially install Thank you |
|
I intend to publish to npm today. But if you'd like to try it out early and provide feedback before I do so, that would be great. To install the latest code from the master branch it's simply
|
taratatach
pushed a commit
to taratatach/chokidar
that referenced
this pull request
Oct 2, 2023
The `napi_external` that maintains the watch on a file is closured into the *stop* function returned by `fsevents.watch`. When that `napi_external` is garbage collected, the callback that was passed in is released and becomes uncallable. When it is called depsite this, the `napi_env` that is passed in is `NULL` which is intended by N-API as a signal that the function is no longer usable. I ignored it in the past, because I always retain the stop function. However a test-script like the one provided provokes this. When garbage collection happens, the `napi_external` is cleared. However there may still be events in the pipeline. And that in turn triggers the crash in paulmillr#355 . I am now handling the `napi_env` as `NULL` signal properly by just dropping the event. In consequence, if you do not retain the *stop* function event reporting simply stops. And this will happen fairly quickly. fixes paulmillr#355
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #273
Resolves #258
When
unwatchfalls back to setting the paths to be ignored, need to ensure the paths are absolute since that's how the relevant objects are keyed.Tweaked the tests to better cover the relative path scenarios as well as address a handful of other issues that caused sporadic failures on Travis.