Make awf and cwd options compatibles #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1392,6 +1392,21 @@ function runTests(options) { | |||
| })(); | |||
| }); | |||
| }); | |||
| it('should be compatible with the cwd option', function(done) { | |||
| var spy = sinon.spy(); | |||
| var testPath = getFixturePath('awf_cwd/awf_cwd.txt'); | |||
There was a problem hiding this comment.
When introducing a new fixture file to the tests it needs to be added to the clean function at the top. Or you could change this to reuse paths that are already on there.
This is likely what caused the tests to explode.
|
@es128 yes, it should be green now. |
|
The failures are the same problematic test that's failing regardless of this PR. Haven't solved it yet, but anyway - doesn't need to hold this one up
Thanks for catching this issue and providing a test & fix! |
es128
added a commit
that referenced
this pull request
Nov 6, 2015
Make awf and cwd options compatibles
taratatach
pushed a commit
to taratatach/chokidar
that referenced
this pull request
Oct 2, 2023
updating workflow to hopefully reenable publishing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, when
awaitWriteFinishandcwdoptions were enabled at the same time andcwdwas not the current directory, noaddevents were fired. It was because thefs.statfailed inawaitWriteFinish.