Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Node.js < 4 #708

Closed
wants to merge 3 commits into from
Closed

Drop support for Node.js < 4 #708

wants to merge 3 commits into from

Conversation

realityking
Copy link

Complimentary to fsevents/fsevents#212, I think it's time to drop Node.js < 4.

The chokidar dependency upath has already dropped support Node.js < 4, this is currently causing CI to fail on 0.10 and 0.12. See these logs for an example: https://travis-ci.org/paulmillr/chokidar/jobs/372092794#L819

Note: Currently CI fails for all Node.js versions - but there are more failures on 0.10 and 0.12 than on the newer versions.

Also fsevents has dropped support for 0.12 (with 0.10 still being supported).

@coveralls
Copy link

coveralls commented Apr 27, 2018

Coverage Status

Coverage decreased (-0.0007%) to 98.501% when pulling edc2f06 on realityking:node-4 into 5e75390 on paulmillr:master.

2 similar comments
@coveralls
Copy link

coveralls commented Apr 27, 2018

Coverage Status

Coverage decreased (-0.0007%) to 98.501% when pulling edc2f06 on realityking:node-4 into 5e75390 on paulmillr:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0007%) to 98.501% when pulling edc2f06 on realityking:node-4 into 5e75390 on paulmillr:master.

@realityking
Copy link
Author

@paulmillr Any interest in merging this?

No matter what happens in fsevents/fsevents#212, chokidar is currently broken on 0.10 and 0.12 anyway because upath already requires Node 4. See Travis tests here: https://travis-ci.org/paulmillr/chokidar/jobs/393728441

Between this one and #709 chokidar would also lose a couple of dependencies which is always nice.

@paulmillr
Copy link
Owner

@realityking upath is devdependency, we need to check if chokidar still runs on v0.12 w/o devdeps

@realityking
Copy link
Author

@paulmillr I don't think it's a dev dependency. It's listed as a dependency

chokidar/package.json

Lines 45 to 58 in 1961427

"dependencies": {
"anymatch": "^2.0.0",
"async-each": "^1.0.0",
"braces": "^2.3.0",
"glob-parent": "^3.1.0",
"inherits": "^2.0.1",
"is-binary-path": "^1.0.0",
"is-glob": "^4.0.0",
"lodash.debounce": "^4.0.8",
"normalize-path": "^2.1.1",
"path-is-absolute": "^1.0.0",
"readdirp": "^2.0.0",
"upath": "^1.0.5"
}

And it's loaded in index.js

var upath = require('upath');

@paulmillr
Copy link
Owner

@realityking the URL you pointed to is related to nyc, not upath. Why do you think upath won't work? https://travis-ci.org/paulmillr/chokidar/jobs/393728441

@realityking
Copy link
Author

@paulmillr You're right! I must've misread the build log.

@paulmillr paulmillr closed this Mar 22, 2019
@paulmillr
Copy link
Owner

live in 3.x branch

@realityking realityking deleted the node-4 branch September 27, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants