-
-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Node.js < 4 #708
Conversation
path.isAbsolute was introduced in Node.js 0.11.2
2 similar comments
@paulmillr Any interest in merging this? No matter what happens in fsevents/fsevents#212, chokidar is currently broken on 0.10 and 0.12 anyway because upath already requires Node 4. See Travis tests here: https://travis-ci.org/paulmillr/chokidar/jobs/393728441 Between this one and #709 chokidar would also lose a couple of dependencies which is always nice. |
@realityking upath is devdependency, we need to check if chokidar still runs on v0.12 w/o devdeps |
@paulmillr I don't think it's a dev dependency. It's listed as a dependency Lines 45 to 58 in 1961427
And it's loaded in index.js Line 13 in 6e112b9
|
@realityking the URL you pointed to is related to |
@paulmillr You're right! I must've misread the build log. |
live in 3.x branch |
Complimentary to fsevents/fsevents#212, I think it's time to drop Node.js < 4.
The chokidar dependency upath has already dropped support Node.js < 4, this is currently causing CI to fail on 0.10 and 0.12. See these logs for an example: https://travis-ci.org/paulmillr/chokidar/jobs/372092794#L819
Note: Currently CI fails for all Node.js versions - but there are more failures on 0.10 and 0.12 than on the newer versions.
Also fsevents has dropped support for 0.12 (with 0.10 still being supported).