Combine String#trim regexes into one. Fixes #284

paulmillr · Sep 3, 2014 · 31f20f4 · 31f20f4 · cscott · Sep 3, 2014
1 parent ff2874d
commit 31f20f4
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/es6-shim.js b/es6-shim.js
@@ -517,17 +517,14 @@
         '\u2004\u2005\u2006\u2007\u2008\u2009\u200A\u202F\u205F\u3000\u2028',
         '\u2029\uFEFF'
       ].join('');
-      var trimBeginRegexp = new RegExp('^[' + ws + '][' + ws + ']*');
-      var trimEndRegexp = new RegExp('[' + ws + '][' + ws + ']*$');
+      var trimRegexp = new RegExp('(^[' + ws + ']+|[' + ws + ']+)$');
       defineProperties(String.prototype, {
         trim: function() {
           if (this === undefined || this === null) {
             throw new TypeError("can't convert " + this + " to object");
           }
-          return String(this)
-            .replace(trimBeginRegexp, "")
-            .replace(trimEndRegexp, "");
-          }
+          return String(this).replace(trimRegexp, "");
+        }
       });
     }