Bug fix for #284 fix (String#trim).

paulmillr · Sep 3, 2014 · eb6ba2e · eb6ba2e
1 parent 31f20f4
commit eb6ba2e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/es6-shim.js b/es6-shim.js
@@ -517,7 +517,7 @@
         '\u2004\u2005\u2006\u2007\u2008\u2009\u200A\u202F\u205F\u3000\u2028',
         '\u2029\uFEFF'
       ].join('');
-      var trimRegexp = new RegExp('(^[' + ws + ']+|[' + ws + ']+)$');
+      var trimRegexp = new RegExp('(^[' + ws + ']+)|([' + ws + ']+$)', 'g');
       defineProperties(String.prototype, {
         trim: function() {
           if (this === undefined || this === null) {

diff --git a/test/string.js b/test/string.js
@@ -444,6 +444,12 @@ var runStringTests = function() {
         expect(trimmed.length).to.equal(1);
         expect(trimmed).to.equal('\u0085');
       });
+
+      it('should trim on both sides', function() {
+        var trimmed = " a ".trim();
+        expect(trimmed.length).to.equal(1);
+        expect(trimmed).to.equal('a');
+      });
     });
   });
 };