-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --polycos option for phase calculation #80
Comments
Indeed! As soon as that is tested and merged, we should take advantage of it! |
However, for NICER data there is a significant optimization needed. It shouldn't be hard but Sasha doesn't have time to work on it. |
@paulray, what is the status of the use of |
It should be working, but it requires barycentered photons. |
This could be implemented at the same time as #28, i.e., psrpipe could call The question is which coordinates to use for the barycentric correction:
Thoughts? |
Yes it could barycenter the data. That would create a new evt file, which would have the phases, but actually the PULSE_PHASE column could even be copied back to the topocentric event file. The barycentering should use the .par file coordinates, but there are options here: (1) use RAJ,DECJ or (2) use RAJ,DECJ accounting for PMRA and PMDEC or (3) use something other than barycorr to do the barycentering. It will be important to match the ephemeris used for barycorr with the one specified in the par file. |
The new option
--polycos
in the PINT photonphase script significantly improves the calculation time for large event files (nanograv/PINT#1199).We should consider adding this option to
psrpipe.py
andmerge.py
.The text was updated successfully, but these errors were encountered: