Accept mix casing exponential notation #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exponential notation in JavaScript accept `e` and `E` for the exponential part of the number. Since you're relying on `from-exponential` which also accepts any casing for the syntax of a number written in exponential notation, I believe it's correct to accept this too, when converting a string into a BigNumber.
|
Thanks for the PR, @tiagox. Sorry for the question above. For some reason, I missed your tests. I will review this later this week. |
Sure, happy to add more tests, is there any case you'd like to cover? I've updated one of the tests you've already had. (I've pushed a couple of time to this branch, sorry I've created to PR before adding tests and checking that everything work) |
Yeah, I see that now! Sorry. Missed them before. |
Repository owner
deleted a comment from
coveralls
Mar 28, 2023
|
Included in v1.2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exponential notation in JavaScript accept
eandEfor the exponential part of the number. Since you're relying onfrom-exponentialwhich also accepts any casing for the syntax of a number written in exponential notation, I believe it's correct to accept this too, when converting a string into a BigNumber.While using
toBnon our project we discovered that a number like'1.2345E+20'was throwing:Unknown format for fixed-point number: 1.2345E+20Our workaround was to change that
Ewith anebut this seems a little bit hacky and it's probably better fortoBnto support this case.