Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test case in ud60x18 powu #24

Closed
PaulRBerg opened this issue May 7, 2021 · 1 comment
Closed

Fix test case in ud60x18 powu #24

PaulRBerg opened this issue May 7, 2021 · 1 comment

Comments

@PaulRBerg
Copy link
Owner

PaulRBerg commented May 7, 2021 •
edited
Loading

One test case for the unsigned pow function checks for the biggest number whose cube fits within MAX_SD59x18:

https://github.com/hifi-finance/prb-math/blob/d625afda3ffdc61f4dac89a7a0019be479b189fe/test/unit/prbMathUd60x18/pure/pow.ts#L70

It should check for the biggest number whose cube fits within MAX_UD60x18.
@PaulRBerg PaulRBerg changed the title Fix test case in ud 60x18 pow Fix test case in ud60x18 powu May 18, 2021
@PaulRBerg
Copy link
Owner Author

PaulRBerg commented May 18, 2021 •
edited
Loading

Fixed in f6e0924.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PaulRBerg