Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename operations to their full name(add -> addition, mul -> multiplication) #39

Closed
AlbertSu123 opened this issue May 30, 2021 · 1 comment
Labels
duplicate This issue or pull request already exists.

Comments

@AlbertSu123
Copy link

Solidity gives the following warning when a instruction from a contract has the same name as an instruction in solidity's assembly.

Warning: Variable is shadowed in inline assembly by an instruction of the same name
--> prb-math/contracts/PRBMathUD60x18.sol:75:5:
75 | function div(uint256 x, uint256 y) internal pure returns (uint256 result) {
| ^ (Relevant source part starts here and spans across multiple lines).

Would you accept a pull request that renames all conflicting operations with their full instruction name?

@PaulRBerg
Copy link
Owner

Closing, duplicate of #35. Let's move the discussion there.

Can you try bump the version of the Solidity compiler to the latest version (0.8.4) and see if that makes the warnings go away?

@PaulRBerg PaulRBerg added the duplicate This issue or pull request already exists. label May 30, 2021
@PaulRBerg PaulRBerg closed this as not planned Won't fix, can't repro, duplicate, stale Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists.
Projects
None yet
Development

No branches or pull requests

2 participants