Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too high outdivider limits max frequency #5

Closed
erikkaashoek opened this issue Jul 26, 2018 · 2 comments
Closed

Too high outdivider limits max frequency #5

erikkaashoek opened this issue Jul 26, 2018 · 2 comments

Comments

@erikkaashoek
Copy link

In the code is says

if (outdivider < 6) {   // low: below 6

but this limits the max output frequency to 150 MHz with maxPLL of 900MHz.

Should it not be

if (outdivider < 4) {   // low: below 4
@pavelmc
Copy link
Owner

pavelmc commented Jul 30, 2018

Thanks for reporting it, at a glance you are right.

I will inspect the code and update it accordingly, also I will try to update some comments that speak about artifacts not in place anymore and that will be misleading.

Cheers, Pavel.

@pavelmc
Copy link
Owner

pavelmc commented Aug 2, 2018

Thanks @erikkaashoek for the bug spotting.

Indeed, after some review I found that I squashed that bug some time ago and make some little improvements in other places, but forgot to sync the changes from the dev PC to the internet!

My bad, sorry.

Bug Closed in commit 9c3cac4

@pavelmc pavelmc closed this as completed Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants