Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't add support RTL in application tag #9

Closed
Kisty opened this issue Jan 4, 2017 · 5 comments
Closed

Don't add support RTL in application tag #9

Kisty opened this issue Jan 4, 2017 · 5 comments

Comments

@Kisty
Copy link
Contributor

Kisty commented Jan 4, 2017

Just added this app and we don't support RTL at present as our app is training material for the UK. Can you remove the supportsRtl attribute from the application in AndroidManifest.xml?

I can replace setting using tools as advised but it would prevent friction for other users.

Error:Execution failed for task ':app:processDevDebugManifest'.
> Manifest merger failed : Attribute application@supportsRtl value=(false) from AndroidManifest.xml:13:9-36
	is also present at [com.github.pavlospt:rxfile:1.5] AndroidManifest.xml:16:9-35 value=(true).
	Suggestion: add 'tools:replace="android:supportsRtl"' to <application> element at AndroidManifest.xml:3:5-18:19 to override.
@Kisty
Copy link
Contributor Author

Kisty commented Jan 4, 2017

Applies to the other attributes. I'd suggest having a clear application tag. Am cooking up a PR.

Kisty added a commit to Kisty/RxFile that referenced this issue Jan 4, 2017
@Kisty
Remove attributes which don't apply to libraries
04751cc 
Removes applying app settings for any apps which depend on the library:
 - support RTL
 - allow backup
 - app name

Having some of these tags can have bad side affects as experienced. For example, if app doesn't support RTL expicitly in the AndroidManifest.xml, the build fails as there are conflicting settings.

Fixes pavlospt#9
This was referenced Jan 4, 2017
Closed
Merged
@Kisty
Copy link
Contributor Author

Kisty commented Jan 4, 2017

CI build failed and can't rebuild from this end. I think it failed from downloading a dependency. Any chance you can trigger a build? I did it by doing the following but there must be a better way.
Project settings -> Test environment -> Test settings on... master > Save & Go

@pavlospt
Copy link
Owner

pavlospt commented Jan 4, 2017

I rerun it manually and it seems to pass now. Something odd might have happened on the previous run.

@Kisty
Copy link
Contributor Author

Kisty commented Jan 4, 2017

That's cool. Odd it happened. Thanks for dealing with it!

@pavlospt
Copy link
Owner

pavlospt commented Jan 4, 2017

No problem thanks for the PR as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pavlospt @Kisty