Bug when serializing exceptions #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nrpc1 and jsonrpc2 implementations
…make badge red, indicating broken build.
…at in coverage report as well.
- Django and Flask are not firm requirements set out in the setup.py so makes sense to not mark the tests as failed if they aren't installed.
Skip django/flask tests if not installed
arnuschky
force-pushed
the
bug-serialize-exceptions
branch
from
8df2062
to
f72f47f
Compare
arnuschky
force-pushed
the
bug-serialize-exceptions
branch
from
f72f47f
to
ea0d859
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Described in #46
Note that this is not a proper fix of the serialization issue. I simple removed
argsfrom the error data reported to the frontend. This is mostly due to the fact that I this this data isn't useful to the frontend. If I hit an unhandled exception, I have to hunt for it in the logs in any case.