Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all executables are found in a shell command on Windows #6

Closed
pawamoy opened this issue Oct 6, 2020 · 1 comment
Closed

Not all executables are found in a shell command on Windows #6

pawamoy opened this issue Oct 6, 2020 · 1 comment
Labels
bug Something isn't working windows Windows OS

Comments

@pawamoy
Copy link
Owner

pawamoy commented Oct 6, 2020

Describe the bug
The first exec of a shell command on Windows is "whiched" to make sure it is found. However a shell command can run multiple executables (with pipes, etc.), so some exec might not be "whiched" and the process results in "exec is not recognized as a command...".

To Reproduce
On Windows, run:

from failprint.runners import run

run("poetry show | grep failprint")

There's a high chance grep is not found.

Expected behavior
Every executable is correctly "whiched". Or some other clever trick.

System:

  • failprint version: 0.4.1
  • Python version: 3.6
  • OS: Windows

Additional context
Aditionally, the output often cannot be decoded as UTF-8 (see #7).

@pawamoy
Copy link
Owner Author

pawamoy commented Jul 29, 2021

I don't see any robust method to prefetch absolute paths of all the executables used in a shell command.
Users will have to make sure they use the absolute path of those execs when they build the command they pass to failprint, if they want it to work on Windows. I can't stand Windows anymore and don't want to waste my time on it :O

@pawamoy pawamoy closed this as completed Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working windows Windows OS
Projects
None yet
Development

No branches or pull requests

1 participant