Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why In Gene class randomProvider.getRandom method has hard coded parameter equal 1000? #61

Closed
KamilKamilS opened this issue Jan 9, 2021 · 1 comment · Fixed by #65
Closed

Why In Gene class randomProvider.getRandom method has hard coded parameter equal 1000? #61

KamilKamilS opened this issue Jan 9, 2021 · 1 comment · Fixed by #65
Assignees
@PawelDabrowski83
Labels
invalid This doesn't seem right question Further information is requested

Comments

@KamilKamilS
Copy link
Collaborator

The value should be 65535 as it is equal to Character.MAX_VAL
@KamilKamilS KamilKamilS added invalid This doesn't seem right question Further information is requested labels Jan 9, 2021
@PawelDabrowski83
Copy link
Owner

I agree.

@PawelDabrowski83 PawelDabrowski83 linked a pull request Jan 10, 2021 that will close this issue
RandomProvider.getRandom argument fix to cover range Character.MIN - MAX_VALUE #65
Merged
@PawelDabrowski83 PawelDabrowski83 self-assigned this Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PawelDabrowski83 PawelDabrowski83

Labels
invalid This doesn't seem right question Further information is requested
Projects
None yet
Milestone
No milestone
2 participants
@PawelDabrowski83 @KamilKamilS