Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BitwiseUtils method should have throws keyword in declaration #80

Closed
KamilKamilS opened this issue Jan 13, 2021 · 2 comments · Fixed by #85
Closed

BitwiseUtils method should have throws keyword in declaration #80

KamilKamilS opened this issue Jan 13, 2021 · 2 comments · Fixed by #85
Labels
enhancement New feature or request question Further information is requested

Comments

@KamilKamilS
Copy link
Collaborator

In BitwiseUtil there are two methods setBit() and setByte(), which throw exceptions. Do you agree that these methods should also declare these exceptions?
@KamilKamilS KamilKamilS added enhancement New feature or request question Further information is requested labels Jan 13, 2021
@PawelDabrowski83
Copy link
Owner

You are right. I think we should use descriptive custom Exceptions extending IllegalArgumentException.

@PawelDabrowski83
Copy link
Owner

I realised my answer was for another question... Let us handle this step by step.

@PawelDabrowski83 PawelDabrowski83 linked a pull request Jan 13, 2021 that will close this issue
80 bitwise should throw exceptions #85
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

80 bitwise should throw exceptions PawelDabrowski83/genAlgo
2 participants
@PawelDabrowski83 @KamilKamilS