Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Application and Bookmark to provide http[s] - take 2 #26

Closed
gitcatpeter opened this issue Jun 11, 2021 · 6 comments · Fixed by #35
Closed

Allow Application and Bookmark to provide http[s] - take 2 #26

gitcatpeter opened this issue Jun 11, 2021 · 6 comments · Fixed by #35
Assignees
Labels
🔨 Feature New feature or request
Milestone

Comments

@gitcatpeter
Copy link

gitcatpeter commented Jun 11, 2021

Since previous attempts were closed without any sensible resolution, I'm opening it again.

It is impossible to use URLs in that form (skipping 'https' or not...):

https://<ip>:<port>
https://<fqdn>:<port>

This is absolutely basic function when it comes to this kind of app. Please make an effort to properly implement it. Not every application offers https redirects and such.

Otherwise it is a great app and would like to use it on daily basis.
Thanks.

@NoLooseEnds
Copy link

I have urls with fqdn:port without issue?

Screenshot 2021-06-11 at 09 08 08

@pawelmalak pawelmalak added the 🔨 Feature New feature or request label Jun 11, 2021
@pawelmalak pawelmalak self-assigned this Jun 11, 2021
@pawelmalak pawelmalak added this to the v1.3 Release milestone Jun 11, 2021
@pawelmalak
Copy link
Owner

I'm working on this url parser and it's currently working with following url formats:

http://www.google.com
https://www.google.com/
www.google.com
http://google.com/
https://google.com
google.com
http://192.168.0.1
192.168.0.1
http://orion2
orion2
http://app.domain.com
https://app.domain.com
app.domain.com
192.168.0.110:5030

Any other urls I should test it with?

@RixzZ
Copy link

RixzZ commented Jun 11, 2021

Not to common, but IP variants with IPv6 might be necessary.

@pawelmalak
Copy link
Owner

I can't access any IPv6 address from any browser so I won't be able to test it.

@gitcatpeter
Copy link
Author

Pawel,
please check the following formats heavily used in homelabs:
https://192.168.5.6:3333
https://app.domain:3333

Right now if you type the whole URL like the above, colon gets removed and the URL does not work. Without 'https://' flame just assumes to use http protocol, which is not supported by the said app.

Thank you for the great work.

@beauwest
Copy link

I'm also looking forward to this. I recently switched everything to HTTPS for my environment, and don't even expose a HTTP port with a redirect. That switch broke my dashboard. This will be nice to have!

@pawelmalak pawelmalak linked a pull request Jun 13, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 Feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants