-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Support for Temporary Credentials (Session Token) in credentials_file_provider()
#280
Comments
Thank you for submitting the issue! This looks like an oversight on our part, but your proposed fix looks like it should solve the issue. I can implement the fix and put it in the next Paws update unless you would prefer to submit your own pull request. |
Thanks! It's probably going to be faster/better if you implement it :) |
Hello, the fix is now available on GitHub. You can get the fixed version by running |
That seems to work perfectly! I did some manual testing in various scenarios and everything worked as expected. Thanks! |
Hello, this bug fix is now in the version on CRAN. Let us know if we can close this issue. Thank you! |
Just did some manual tests on this from CRAN and it works perfectly 👍 |
Paws supports temporary AWS credentials with session tokens except in the case where credentials are provided in a credentials file. Unfortunately for me, that's where my session token is stored :)
I think it would be an easy improvement. In the
credentials_file_provider()
method ofcredential_providers.R
we just need to read out the session token withand pass the result to
creds()
.For context, the case where session token is stored in the environment was improved in #185, and there's an excellent workaround in #210 , so this is clearly not a high priority -- it would just make authentication a little more consistent.
The text was updated successfully, but these errors were encountered: