-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KerasGRU4Rec does not process on all possible events #6
Comments
Hi there @htran20, thanks for reporting this!
|
Hey guys! Is there any update for [2]? |
Hey there @shinsenter! I haven't looked into (2), nor evaluated the potential impact on evaluation metrics. Your comment has been a good reminder of this issue. I'll try to address it in the coming weeks, but no promises. If you want to take a stab at it, I'd also be happy to review any pull requests 👍 |
@paxcema thank you for giving a schedule. |
Thanks for the implementation of Keras gru4rec.
I notify some issues in your code:
This can affect the evaluation result where number of batch_size is large and number of unique session is small. One potential fix is to use zero masking.
The text was updated successfully, but these errors were encountered: