Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Download via non-ajax requests fail/FISH-7644 #6340

Open
LarsBrenker opened this issue Jul 19, 2023 · 8 comments
Open

Bug Report: Download via non-ajax requests fail/FISH-7644 #6340

LarsBrenker opened this issue Jul 19, 2023 · 8 comments
Assignees
Labels
Status: Accepted Confirmed defect or accepted improvement to implement, issue has been escalated to Platform Dev Type: Bug Label issue as a bug defect

Comments

@LarsBrenker
Copy link

Brief Summary

After migrating from Jakarta EE 8 (Payara 5.x) to Jakarta EE 10 (Payara 6.2023.4) we have problems with file download via Primefaces. The problem occurs as soon as the server is behind a proxy. The problem does not occur locally.

The problem has already been discussed in several forums:
https://forum.primefaces.org/viewtopic.php?t=80045
primefaces/primefaces#9702
eclipse-ee4j/mojarra#5202

The problem was localized in Mojarra 4.0 and fixed with 4.0.2 (eclipse-ee4j/mojarra#5165 / eclipse-ee4j/mojarra#5166) .

We were able to solve the problem by setting the parameter useBundledJsf=true via payara-web.xml and delivering Mojarra 4.0.2 ourselves.

It would be great if you integrated Mojarra 4.0.2 in Payara in a timely manner.

Expected Outcome

Payara supports and delivers Mojarra 4.0.2

Current Outcome

Download via non-ajax requests fail because an attribute is missing in class impl/src/main/java/com/sun/faces/context/ExternalContextImpl.java

Reproducer

I think a reproducer is not necessary.

If you need a reproducer please let me know.

However, this would then have to run behind a proxy in order to represent the problem.

Operating System

Linux

JDK Version

Amazon Corretto 17

Payara Distribution

Payara Micro

@LarsBrenker LarsBrenker added Status: Open Issue has been triaged by the front-line engineers and is being worked on verification Type: Bug Label issue as a bug defect labels Jul 19, 2023
@LarsBrenker LarsBrenker changed the title Bug Report: Bug Report: Download via non-ajax requests fail Jul 19, 2023
@felixif
Copy link

felixif commented Jul 20, 2023

Hello @LarsBrenker,

Most of the time a reproducer would be useful, but it seems that you already pointed down the issue to the version of mojarra. I have raised an internal issue FISH-7644, in which I described the issue and pinpointed that the solution should be an upgrade to Mojarra 4.0.2. Thank you for reporting this issue!

Best regards,
Felix Ifrim

@felixif felixif added Status: Accepted Confirmed defect or accepted improvement to implement, issue has been escalated to Platform Dev and removed Status: Open Issue has been triaged by the front-line engineers and is being worked on verification labels Jul 20, 2023
@LarsBrenker
Copy link
Author

Hi @felixif , I can understand your objection regarding the reproducer. I have always delivered a reproducer so far. In my opinion, however, the effort here is not in proportion to the benefit, since in my opinion it makes sense to import the Mojarra patch anyway.

Thank you for forwarding it to development.

@felixif
Copy link

felixif commented Jul 20, 2023

Hi @LarsBrenker,

I do not have any objections when it comes to you not providing the reproducer. I appreciate your analysis, I know you have been contributing with issue reports for a while, and we really appreciate your input on the product. I apologise if it came across as an objection.

@LarsBrenker
Copy link
Author

No, everything is OK. I didn't take it as an objection. I just wanted to say that I think it's good to create reproducers in general. We look forward to the hot fix.

@StrongKeyAbhishek
Copy link

This issues is still reproducible in 6.2023.10, is there any update on when this fix will be released with the updated Mojarra?

@felixif felixif changed the title Bug Report: Download via non-ajax requests fail Bug Report: Download via non-ajax requests fail/FISH-7644 Oct 25, 2023
@felixif
Copy link

felixif commented Oct 25, 2023

@StrongKeyAbhishek, I have verified the issue, but sadly it still sits in the backlog.
I updated the internal issue, stating that it is still reproducible in Payara 6.2023.10 and 6.7.0. I will discuss this issue in the next team meeting, and see if we can prioritize it. Thank you very much for updating this issue and bringing attention to it.

@tuerker
Copy link

tuerker commented May 10, 2024

This issue still persists in Payara 6.2024.3 in May 2024.

Would be great to fix this problem asap. Many thanks in advance

@lprimak
Copy link
Contributor

lprimak commented May 10, 2024

Yet another reason to move to updated Mojrarra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Confirmed defect or accepted improvement to implement, issue has been escalated to Platform Dev Type: Bug Label issue as a bug defect
Projects
None yet
Development

No branches or pull requests

5 participants