PAYARA-546 Allow setting SO_KeepAlive on the server side. #3533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lprimak
approved these changes
Dec 21, 2018
| @@ -105,10 +106,9 @@ | |||
| private static final String PERSISTENT_SSL = "PERSISTENT_SSL"; | |||
|
|
|||
| private static final int BACKLOG = 50; | |||
|
|
|||
| private static final String SO_KEEPALIVE = "fish.payara.SOKeepAlive"; | |||
There was a problem hiding this comment.
I think the case of this property is so complicated, it will lead to issues.
May I suggest fish.payara.so-keepalive
|
jenkins test |
MattGill98
reviewed
Jan 2, 2019
| // Enable or disable SO_KEEPALIVE for the socket as required | ||
| try { | ||
| if (Boolean.getBoolean(IIOPSSLSocketFactory.SO_KEEPALIVE) && !socket.getKeepAlive()) { | ||
| if (logger.isLoggable(Level.FINER)) { |
There was a problem hiding this comment.
I'm not a fan of this logger statement being so frequent. Feel free to ignore this if you disagree, but when this log level is enabled you'll likely get an absolute tonne of these messages. All except the first one (I think) will be unnecessary. It would possibly be better to add a method to check if it's changed and log if it does. This could by all means still be called from this method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set via a SystemProperty on all IIOP listeners.
Follow up PR (#3534) is a provisionary improvement that needs a fine-grained review as I'm not convinced that it'll work on multi-homed environments.