Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Replace DTO's with Fluent objects. #80

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Conversation

r-kujawa
Copy link
Contributor

What does this PR do? 🤖

  • Replaces the Provider::class DTO with Provider::class Fluent object.
  • Replaces the Account::class DTO with Account::class Fluent object.
  • 💅🏼 Some additional quality of code improvements.

Does this relate to any issue? 🔗

Closes #72

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.14%. Comparing base (ebeee27) to head (f9b9856).

Files Patch % Lines
src/Fluent/Provider.php 80.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #80      +/-   ##
============================================
- Coverage     93.09%   92.14%   -0.95%     
+ Complexity      190      189       -1     
============================================
  Files            22       22              
  Lines           666      662       -4     
============================================
- Hits            620      610      -10     
- Misses           46       52       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r-kujawa r-kujawa merged commit e2cf082 into master Jun 26, 2024
5 checks passed
@r-kujawa r-kujawa deleted the enhancement-72-fluent_dto branch June 26, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants