Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DTOs Fluent. #72

Closed
r-kujawa opened this issue May 28, 2024 · 1 comment
Closed

Make DTOs Fluent. #72

r-kujawa opened this issue May 28, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@r-kujawa
Copy link
Contributor

r-kujawa commented May 28, 2024

Describe the solution you'd like. ✈️

Extend Laravel's Fluent::class for the following DTOs:

  1. Payavel\Orchestration\DataTransferObjects\Service::class
  2. Payavel\Orchestration\DataTransferObjects\Provider::class
  3. Payavel\Orchestration\DataTransferObjects\Account::class

What problem will this solve? 🔥

Improves the DX.

Which version(s) should this be pointed at?

Probably 3.0 since it would result in a breaking change, as we might need to remove the SimulatesAttributes trait in favor of the Fluent::class's magic methods. But maybe there is a possibility to duplicate these DTOs in 2.x and deprecate the existing ones.

@r-kujawa r-kujawa added the enhancement New feature or request label May 28, 2024
@r-kujawa r-kujawa added good first issue Good for newcomers labels Jun 11, 2024
@r-kujawa
Copy link
Contributor Author

Let's deal with #73 before this one. To prevent double work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant