Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: some custom components were not handled properly if they are RSCs #6315

Merged
merged 1 commit into from
May 13, 2024
Merged

fix!: some custom components were not handled properly if they are RSCs #6315

merged 1 commit into from
May 13, 2024

Conversation

AlessioGr
Copy link
Member

@AlessioGr AlessioGr commented May 10, 2024 •
edited
Loading

Description

Breaking: The following, exported components now need the payload object as a prop rather than the config object:

  • RenderCustomComponent (optional)
  • Logo
  • DefaultTemplate
  • DefaultNav

Some custom components were not handled properly if they were RSCs, which means they wouldn't receive the payload prop.

  • I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

  • Chore (non-breaking change which does not add functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Change to the templates directory (does not affect core functionality)
  • Change to the examples directory (does not affect core functionality)
  • This change requires a documentation update

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • Existing test suite passes locally with my changes
  • I have made corresponding changes to the documentation

@AlessioGr AlessioGr changed the title fix: some RSC custom components not handled properly fix!: some custom components were not handled properly if they are RSCs May 13, 2024
@AlessioGr AlessioGr merged commit 0d98b4b into beta May 13, 2024
37 checks passed
@AlessioGr AlessioGr deleted the fix/missin-rsc-handling branch May 13, 2024 16:05
JessChowdhury pushed a commit that referenced this pull request May 14, 2024
@AlessioGr @JessChowdhury
fix!: some custom components were not handled properly if they are RS…
cc50dcb 
…Cs (#6315)

**Breaking:** The following, exported components now need the `payload` object as a prop rather than the `config` object:
- `RenderCustomComponent` (optional)
- `Logo`
- `DefaultTemplate`
- `DefaultNav`
JessChowdhury pushed a commit that referenced this pull request May 14, 2024
@AlessioGr @JessChowdhury
fix!: some custom components were not handled properly if they are RS…
6d7e1b9 
…Cs (#6315)

**Breaking:** The following, exported components now need the `payload` object as a prop rather than the `config` object:
- `RenderCustomComponent` (optional)
- `Logo`
- `DefaultTemplate`
- `DefaultNav`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobsfletch jacobsfletch jacobsfletch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlessioGr @jacobsfletch