Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some Econet numbers regarded as invalid #7

Closed
tzifudzi opened this issue Nov 24, 2018 · 2 comments
Closed

Some Econet numbers regarded as invalid #7

tzifudzi opened this issue Nov 24, 2018 · 2 comments
Labels
bug Something isn't working

Comments

@tzifudzi
Copy link
Collaborator

tzifudzi commented Nov 24, 2018 •
edited
Loading

Econet phone numbers beginning with 0771, 0776, 0777 and 0778 are all matched as invalid numbers with the regex specified in the Paynow.java file. Note that numbers beginning with these digits exist.

Is this an intended requirement? Or can these numbers also perform mobile transactions.
@iammerus
Copy link
Contributor

iammerus commented Dec 9, 2018

After going through the SDK, that seems to be a bug with the said regex. We might need to just remove that check since the Paynow API will return an error for invalid numbers.

@iammerus iammerus added the bug Something isn't working label Dec 9, 2018
iammerus added a commit that referenced this issue Dec 19, 2018
@iammerus
Remove phone number validation
4e4db6e 
Remove check for mobile number using regex since paynow validates mobile numbers as outlined in issue #7 brought up by @tzifudzi
@iammerus
Copy link
Contributor

This was resolved in commit 4e4db6e

tzifudzi pushed a commit that referenced this issue Feb 4, 2019
@iammerus
Remove phone number validation
f7f27c0 
Remove check for mobile number using regex since paynow validates mobile numbers as outlined in issue #7 brought up by @tzifudzi
tzifudzi pushed a commit that referenced this issue Feb 26, 2019
@iammerus
Remove phone number validation
01ce2f6 
Remove check for mobile number using regex since paynow validates mobile numbers as outlined in issue #7 brought up by @tzifudzi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tzifudzi @iammerus