Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests fail because of wrong module sequence #95

Closed
domeglic opened this issue Aug 28, 2017 · 4 comments
Closed

Integration tests fail because of wrong module sequence #95

domeglic opened this issue Aug 28, 2017 · 4 comments

Comments

@domeglic
Copy link

When running integration tests on a project with this module it will fail with the message:

Base table or view not found: 1146 Table 'integration_test.quote_address' doesn't exist, query was: DESCRIBE quote_address

Since there is no sequence defined, this modules setup is run very early and fails because quote tables have not been created yet.
Adding Magento_Quote to the sequence fixes the problem (Should probably also add Magento_Sales since order tables are being changed to be more correct).

Would be really helpful since it should not break anything and there is no way to add a sequence to another module as far as I know.

@fjbender
Copy link
Contributor

Thanks for the feedback!

Just to be sure: You're referencing to the <sequence> Tags in our module.xml file as defined in http://devdocs.magento.com/guides/v2.0/extension-dev-guide/build/module-load-order.html, right?

Altering the file this way would suffice?

<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../lib/internal/Magento/Framework/Module/etc/module.xsd">
    <module name="Payone_Core" setup_version="1.3.4">
        <sequence>
            <module name="Magento_Quote" />
            <module name="Magento_Sales" />
        </sequence>
    </module>
</config>

@domeglic
Copy link
Author

Yes exactly.

@fjbender
Copy link
Contributor

@domeglic Can you confirm that the integration tests run with my changes from #96?

@domeglic
Copy link
Author

I have tested it and can confirm that fix #96 solves the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants