refactor: chunk multi-message rendering to prevent singular long task #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seavenly
reviewed
Jun 5, 2023
Seavenly
reviewed
Jun 6, 2023
| if (err.message === 'offer_validation_error') { | ||
| return undefined; | ||
| if (mapIndex === 0) { | ||
| return renderOrUpdateMessage(); |
There was a problem hiding this comment.
We can remove the consistent-return eslint warning by updating this slightly
Suggested change
| return renderOrUpdateMessage(); | |
| renderOrUpdateMessage(); | |
| return; |
Comment on lines
61
to
65
| /* eslint-disable-next-line promise/no-native, compat/compat */ | ||
| Promise.all( | ||
| validContainers.map((container, mapIndex) => { | ||
| /* eslint-disable-next-line promise/no-native, compat/compat, consistent-return */ | ||
| return new Promise((resolve, reject) => { |
There was a problem hiding this comment.
Based on the previous comment we can't make this change?
Suggested change
| /* eslint-disable-next-line promise/no-native, compat/compat */ | |
| Promise.all( | |
| validContainers.map((container, mapIndex) => { | |
| /* eslint-disable-next-line promise/no-native, compat/compat, consistent-return */ | |
| return new Promise((resolve, reject) => { | |
| ZalgoPromise.all( | |
| validContainers.map((container, mapIndex) => { | |
| return new ZalgoPromise((resolve, reject) => { |
There was a problem hiding this comment.
When I removed the promises for zalgopromise I forgot to add back the new ZalgoPromise((resolve, reject) portion. Thats why I couldn't get it to return
Seavenly
changed the title
Seavenly
approved these changes
Jun 7, 2023
|
🎉 This PR is included in version 1.43.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
## [1.43.0](v1.42.0...v1.43.0) (2023-06-14) ### Features * Update UK Pi3 Legal Disclosure (DTCRCMERC-2267) ([#936](#936)) ([a186771](a186771)) ### Bug Fixes * add cookie global ([#951](#951)) ([a12ebb3](a12ebb3)) ### Build System * remove old stage bundle url ([#947](#947)) ([c669016](c669016)) ### Continuous Integration * Github action workflow npm publish ([#923](#923)) ([0e38156](0e38156)) * remove use of deprecated set-output command ([#938](#938)) ([9ef6eb0](9ef6eb0)) ### Code Refactoring * chunk multi-message rendering to prevent singular long task ([#939](#939)) ([9b1a240](9b1a240)) * remove NE from US Pay Monthly modal legal disclosure ([#906](#906)) ([eb9ffb0](eb9ffb0))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Break up the long running tasks