-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No Ruby 3 support #12
Comments
One potential simple fix for the |
See #18 or a quick fix: module URI
# for PayPal client
def self.escape(string)
URI.encode_www_form_component(string).gsub('+', '%20')
end
end |
Any chance of getting this fixed now that ruby 3.1 is out? |
|
stripe doesn't have paypal support ;)
…On Mon, Jan 03, 2022 at 19:27:15, darkBuddha < ***@***.*** > wrote:
>
>
> Any chance of getting this fixed now that ruby 3.1 is out?
>
>
https:/ / stripe. com/ docs/ api?lang=ruby (
https://stripe.com/docs/api?lang=ruby )
—
Reply to this email directly, view it on GitHub (
#12 (comment)
) , or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AOASD56N5644CM3CQGVOXLLUUHTAHANCNFSM5EFZFU5A
).
Triage notifications on the go with GitHub Mobile for iOS (
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
) or Android (
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
).
You are receiving this because you commented. Message ID: <paypal/paypalhttp_ruby/issues/12/1004274451
@ github. com>
|
Stripe doesn't block developers (paying customers) from upgrading their projects... |
you can use the monkey patch or my branch in the fork, or make your own fork. I agree PayPal is technically horrible (the developer docs are the worst website on the internet) but hey people like to use paypal (I do) |
Thanks man, great work! |
This is fixed in v2.0.0, which was just released. |
Unfortunately the paypal-checkout-sdk gem is now deprecated, and the old versions are incompatible with the recently fixed paypalhttp gem. If somebody needs this as urgently as I do, please feel free to use my fork. In the Gemfile:
It seems to work fine. |
PayPal has stopped supporting its Ruby SDK [1]. From its README: > This SDK is deprecated. You can continue to use it, but no new features or support requests will be accepted. For alternatives, please visit the current SDK homepage on the PayPal Developer Portal From the PR [2] that introduced the deprecation message: > There is no team at PayPal that supports this repo right now (and, in > fact, the documentation for SDK has been removed from the PayPal docs > site). > > My team is in the process of creating replacement SDKs for integrating > with PayPal, but until those are available our official recommendation > is to do one of the following: > > A) Use the API directly > B) Continue using the current SDK, but know that no further updates > will be made outside of necessary security updates On top of that, the SDK is locked to paypalhttp_ruby lesser than 2 [3], but Ruby 3 is only supported since that version [4]. That combines to make it impossible to use Ruby > 3 + Solidus + PayPal extension. If PayPal restarts giving support to Ruby, we'll add it again as an option in the installer for solidus_frontend [5]. [1] - https://github.com/paypal/Checkout-Ruby-SDK [2] - https://github.com/paypal/Checkout-Ruby-SDK/pull/34#issuecomment-1190523120 [3] - https://github.com/paypal/Checkout-Ruby-SDK/blob/7170ecd5656d9e9f96a4d0ce0ee31b59b3a8268b/paypal-checkout-sdk.gemspec#L22 [4] - paypal/paypalhttp_ruby#12 (comment) [5] - https://github.com/solidusio/solidus_frontend/blob/master/lib/generators/solidus_frontend/install/install_generator.rb
PayPal has stopped supporting its Ruby SDK [1]. From its README: > This SDK is deprecated. You can continue to use it, but no new features or support requests will be accepted. For alternatives, please visit the current SDK homepage on the PayPal Developer Portal From the PR [2] that introduced the deprecation message: > There is no team at PayPal that supports this repo right now (and, in > fact, the documentation for SDK has been removed from the PayPal docs > site). > > My team is in the process of creating replacement SDKs for integrating > with PayPal, but until those are available our official recommendation > is to do one of the following: > > A) Use the API directly > B) Continue using the current SDK, but know that no further updates > will be made outside of necessary security updates On top of that, the SDK is locked to paypalhttp_ruby lesser than 2 [3], but Ruby 3 is only supported since that version [4]. That combines to make it impossible to use Ruby > 3 + Solidus + PayPal extension. If PayPal restarts giving support to Ruby, we'll add it again as an option in the installer for solidus_frontend [5]. [1] - https://github.com/paypal/Checkout-Ruby-SDK [2] - https://github.com/paypal/Checkout-Ruby-SDK/pull/34#issuecomment-1190523120 [3] - https://github.com/paypal/Checkout-Ruby-SDK/blob/7170ecd5656d9e9f96a4d0ce0ee31b59b3a8268b/paypal-checkout-sdk.gemspec#L22 [4] - paypal/paypalhttp_ruby#12 (comment) [5] - https://github.com/solidusio/solidus_frontend/blob/master/lib/generators/solidus_frontend/install/install_generator.rb
for good measure, since we can't rely on trust on such a sensitive area as payments, pin the commit on the fork ;)
|
General information
Issue description
The gem should support the latest Ruby version. It offers major advantages over Ruby 2.
The text was updated successfully, but these errors were encountered: