Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Ruby 3 support #12

Closed
darkBuddha opened this issue Sep 16, 2021 · 11 comments
Closed

No Ruby 3 support #12

darkBuddha opened this issue Sep 16, 2021 · 11 comments

Comments

@darkBuddha
Copy link

General information

  • SDK/Library version: 1.0.1
  • Ruby Version: 3.0.2

Issue description

The gem should support the latest Ruby version. It offers major advantages over Ruby 2.

@Sexual
Copy link

Sexual commented Dec 26, 2021

One potential simple fix for the URI.escape removal?: https://github.com/rollbar/rollbar-gem/pull/988/files

@dorianmariecom
Copy link

See #18

or a quick fix:

module URI
  # for PayPal client
  def self.escape(string)
    URI.encode_www_form_component(string).gsub('+', '%20')
  end
end

@plerohellec
Copy link

Any chance of getting this fixed now that ruby 3.1 is out?

@darkBuddha
Copy link
Author

Any chance of getting this fixed now that ruby 3.1 is out?

https://stripe.com/docs/api?lang=ruby

@dorianmariecom
Copy link

dorianmariecom commented Jan 3, 2022 via email

@darkBuddha
Copy link
Author

darkBuddha commented Jan 5, 2022

stripe doesn't have paypal support ;)

Stripe doesn't block developers (paying customers) from upgrading their projects...

@dorianmariecom
Copy link

you can use the monkey patch or my branch in the fork, or make your own fork. I agree PayPal is technically horrible (the developer docs are the worst website on the internet) but hey people like to use paypal (I do)

@darkBuddha
Copy link
Author

darkBuddha commented Jan 5, 2022

you can use the monkey patch or my branch in the fork

Thanks man, great work!

@crookedneighbor
Copy link

This is fixed in v2.0.0, which was just released.

@darkBuddha
Copy link
Author

darkBuddha commented Aug 5, 2022

Unfortunately the paypal-checkout-sdk gem is now deprecated, and the old versions are incompatible with the recently fixed paypalhttp gem.

If somebody needs this as urgently as I do, please feel free to use my fork.

In the Gemfile:

gem 'paypalhttp', '~> 2.0.0'
gem 'paypal-checkout-sdk', git: 'https://github.com/darkBuddha/Checkout-Ruby-SDK.git', ref: 'f1aab0f4e367aad1de937bba6cbc4abb22900339'

It seems to work fine.

waiting-for-dev added a commit to nebulab/solidus that referenced this issue Aug 8, 2022
PayPal has stopped supporting its Ruby SDK [1]. From its README:

> This SDK is deprecated. You can continue to use it, but no new
features or support requests will be accepted. For alternatives, please
visit the current SDK homepage on the PayPal Developer Portal

From the PR [2] that introduced the deprecation message:

> There is no team at PayPal that supports this repo right now (and, in
> fact, the documentation for SDK has been removed from the PayPal docs
> site).
>
> My team is in the process of creating replacement SDKs for integrating
> with PayPal, but until those are available our official recommendation
> is to do one of the following:
>
> A) Use the API directly
> B) Continue using the current SDK, but know that no further updates
> will be made outside of necessary security updates

On top of that, the SDK is locked to paypalhttp_ruby lesser than 2 [3],
but Ruby 3 is only supported since that version [4]. That combines to
make it impossible to use Ruby > 3 + Solidus + PayPal extension.

If PayPal restarts giving support to Ruby, we'll add it again as an
option in the installer for solidus_frontend [5].

[1] - https://github.com/paypal/Checkout-Ruby-SDK
[2] - https://github.com/paypal/Checkout-Ruby-SDK/pull/34#issuecomment-1190523120
[3] - https://github.com/paypal/Checkout-Ruby-SDK/blob/7170ecd5656d9e9f96a4d0ce0ee31b59b3a8268b/paypal-checkout-sdk.gemspec#L22
[4] - paypal/paypalhttp_ruby#12 (comment)
[5] - https://github.com/solidusio/solidus_frontend/blob/master/lib/generators/solidus_frontend/install/install_generator.rb
waiting-for-dev added a commit to nebulab/solidus that referenced this issue Aug 8, 2022
PayPal has stopped supporting its Ruby SDK [1]. From its README:

> This SDK is deprecated. You can continue to use it, but no new
features or support requests will be accepted. For alternatives, please
visit the current SDK homepage on the PayPal Developer Portal

From the PR [2] that introduced the deprecation message:

> There is no team at PayPal that supports this repo right now (and, in
> fact, the documentation for SDK has been removed from the PayPal docs
> site).
>
> My team is in the process of creating replacement SDKs for integrating
> with PayPal, but until those are available our official recommendation
> is to do one of the following:
>
> A) Use the API directly
> B) Continue using the current SDK, but know that no further updates
> will be made outside of necessary security updates

On top of that, the SDK is locked to paypalhttp_ruby lesser than 2 [3],
but Ruby 3 is only supported since that version [4]. That combines to
make it impossible to use Ruby > 3 + Solidus + PayPal extension.

If PayPal restarts giving support to Ruby, we'll add it again as an
option in the installer for solidus_frontend [5].

[1] - https://github.com/paypal/Checkout-Ruby-SDK
[2] - https://github.com/paypal/Checkout-Ruby-SDK/pull/34#issuecomment-1190523120
[3] - https://github.com/paypal/Checkout-Ruby-SDK/blob/7170ecd5656d9e9f96a4d0ce0ee31b59b3a8268b/paypal-checkout-sdk.gemspec#L22
[4] - paypal/paypalhttp_ruby#12 (comment)
[5] - https://github.com/solidusio/solidus_frontend/blob/master/lib/generators/solidus_frontend/install/install_generator.rb
@xeruf
Copy link

xeruf commented Sep 29, 2022

for good measure, since we can't rely on trust on such a sensitive area as payments, pin the commit on the fork ;)

gem 'paypal-checkout-sdk', git: 'https://github.com/darkBuddha/Checkout-Ruby-SDK.git', :ref => 'f1aab0f4e367aad1de937bba6cbc4abb22900339'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants