Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#711 Make service infra startup timeout configurable #724

Merged
merged 7 commits into from
Jun 19, 2019

Conversation

crankydillo
Copy link
Contributor

Tests and documentation TBD.

  • [ x] Title includes issue id.
  • [ x] Description of the change added.
  • Commits are squashed.
  • Tests added.
  • Documentation added/updated.
  • [ x] Also please review CONTRIBUTING.md.

# (i.e. Squbs listeners). The default timeout is (number of listeners * 10) seconds. This timeout
# applies to both the wait time for a response from each listener and the overall time it takes for
# all listeners to start.
# service-infra-timeout = 1 minute
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line service-infra-timeout = 1 minute supposed to be commented out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, in order to preserve existing behavior, which is to have the timeout be governed by the number of listeners. Your question is making me think about the doc effort though. I may put something in the timeout error message about this config).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically the reference.conf is for capturing the default settings here. "over-rides" of the default are typically in application.conf. Also I believe having this timeout value be both the per listener timeout as well as the total timeout might be confusing to users.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to have 2 timeouts and the values are not commented out.

sebady
sebady previously approved these changes Jun 19, 2019
Copy link
Contributor

@sebady sebady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sebady sebady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebady sebady merged commit cb218d9 into paypal:master Jun 19, 2019
@sebady sebady changed the title #711 [WIP] Make service infra startup timeout configurable #711 Make service infra startup timeout configurable Jun 19, 2019
akara pushed a commit that referenced this pull request Jun 22, 2019
*  #711 Fix comments

*  #711 remove unnecessary foreach
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants