Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service infra timeout needs to be more configurable #711

Closed
crankydillo opened this issue Mar 11, 2019 · 2 comments
Closed

Service infra timeout needs to be more configurable #711

crankydillo opened this issue Mar 11, 2019 · 2 comments
Assignees
@crankydillo
Labels
fixed
Milestone
0.13.0

Comments

@crankydillo
Copy link
Contributor

crankydillo commented Mar 11, 2019 •
edited
Loading

From what I can tell, the only way to increase the service infra timeout is to run additional listeners (source). We need to be able to change that service infra start timeout via configuration..

Update: Make sure you have good error messages. The code as it stand at time of writing uses the same string for both a timeout and a 'start failure', which may also be a timeout failure. So when you get a timeout, it's not crystal clear if the timeout is happening in the proposed 'fix' or some underlying layer.
@akara
Copy link
Contributor

akara commented Mar 12, 2019

In essence, make the timeout in startServiceInfra configurable. Sure.

@crankydillo crankydillo mentioned this issue Mar 12, 2019
Open
@crankydillo crankydillo self-assigned this Jun 18, 2019
crankydillo pushed a commit to crankydillo/squbs that referenced this issue Jun 18, 2019
paypal#711 [WIP] Make service infra startup timeout configurable
6747d30 
Tests TBD.
crankydillo pushed a commit to crankydillo/squbs that referenced this issue Jun 18, 2019
paypal#711 Update doc a bit
6e03bb6
crankydillo pushed a commit to crankydillo/squbs that referenced this issue Jun 18, 2019
paypal#711 Trusing my IDE just a bit too much:P
0766a11
@crankydillo crankydillo mentioned this issue Jun 19, 2019
Open
crankydillo pushed a commit to crankydillo/squbs that referenced this issue Jun 19, 2019
paypal#711 Tests and refactor to have 2 timeouts.
799babb
crankydillo pushed a commit to crankydillo/squbs that referenced this issue Jun 19, 2019
paypal#711 Fix listener timeout default
e6f424d
crankydillo pushed a commit to crankydillo/squbs that referenced this issue Jun 19, 2019
paypal#711 Nope I had it right (and should have reverted:)
0e12363
crankydillo pushed a commit to crankydillo/squbs that referenced this issue Jun 19, 2019
paypal#711 forgot to check in these artifacts
c9eaaff
sebady pushed a commit that referenced this issue Jun 19, 2019
@crankydillo @sebady
#711 [WIP] Make service infra startup timeout configurable (#724)
cb218d9 
*  #711 Make service infra startup timeout configurable
crankydillo pushed a commit to crankydillo/squbs that referenced this issue Jun 19, 2019
paypal#711 Update comment
36a2027
crankydillo pushed a commit to crankydillo/squbs that referenced this issue Jun 19, 2019
paypal#711 Fix comments
99d3fe2
crankydillo pushed a commit to crankydillo/squbs that referenced this issue Jun 20, 2019
paypal#711 remove unnecessary foreach
e5734ae
akara pushed a commit that referenced this issue Jun 22, 2019
@crankydillo @akara
#711 Some minor tweaks to #724 work (#726)
af38fa2 
*  #711 Fix comments

*  #711 remove unnecessary foreach
crankydillo pushed a commit to crankydillo/squbs that referenced this issue Aug 9, 2019
paypal#711 proposal for better error messages..
e7b2a3d 
End users might be confused, but this should help us a bit if we have to
triage.
crankydillo pushed a commit to crankydillo/squbs that referenced this issue Aug 9, 2019
paypal#711 proposal for better error messages..
598bc98 
End users might be confused, but this should help us a bit if we have to
triage.
@crankydillo crankydillo added this to the 0.13.0 milestone Aug 15, 2019
crankydillo added a commit that referenced this issue Aug 15, 2019
@crankydillo
#711 proposal for better error messages.. (#728)
5720a0b 
End users might be confused, but this should help us a bit if we have to
triage.
@crankydillo
Copy link
Contributor Author

Work done in linked PRs.

crankydillo pushed a commit to crankydillo/squbs that referenced this issue Aug 15, 2019
paypal#711 Document service infra timeouts.
44aa816
crankydillo pushed a commit to crankydillo/squbs that referenced this issue Aug 16, 2019
paypal#711 Document service infra timeouts and fix typo.
58ec5d6
anilgursel pushed a commit that referenced this issue Aug 16, 2019
@anilgursel
#711 Document service infra timeouts and fix typo.
7c0ec73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crankydillo crankydillo

Labels
fixed
Projects
None yet
Milestone
0.13.0
Development

No branches or pull requests
2 participants
@akara @crankydillo