Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release uses non-compiled version #32

Open
rchl opened this issue Jun 8, 2020 · 1 comment
Open

Release uses non-compiled version #32

rchl opened this issue Jun 8, 2020 · 1 comment

Comments

@rchl
Copy link

rchl commented Jun 8, 2020

Why are you compiling the code and at the same time have main set to uncompiled version?

"main": "lib/index.js",

That means that users are gonna use an uncompiled version if they import directly from the module.

Also, when using a compiled version, don't include original sources in released package to make the package smaller.

@rchl
Copy link
Author

rchl commented Jun 8, 2020

Well, I see that both lib and dist are compiled (by babel and webpack respectively). Still, I don't understand the reasoning and I don't think that's correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant