__computeScrollMax computes wrong values

[niieani]

Hi there.
I've been using the Scroller for my last university project and it's really great!
But there's an error in logic that __computeScrollMax uses to compute the __maxScroll values.

As it is at the moment, the values computed are too large when zooming in on canvas elemenets:

self.__maxScrollLeft = Math.max((self.__contentWidth * zoomLevel) - self.__clientWidth, 0);
self.__maxScrollTop = Math.max((self.__contentHeight * zoomLevel) - self.__clientHeight, 0);

I've corrected the problem here:

self.__maxScrollLeft = Math.max(self.__contentWidth - (self.__clientWidth * (1/zoomLevel)), 0);
self.__maxScrollTop = Math.max(self.__contentHeight - (self.__clientHeight * (1/zoomLevel)), 0);

Cheers!

[niieani]

Actually, this seems quite odd, but the logic works differently in different examples.
For example when scaling the context of the canvas (ctx.scale) my logic works, but when redrawing the components like you do in the canvas example your logic works.
Maybe there should be a way to override the default logic in case of a different implementation of the rendering?

[swernerx]

It mainly depends on whether your properties apply zooming on top of dimensions or the other way around. This is the reason why we recompute the dimensions and positions based on zooming in some examples and do not so in others.