Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Show previous path in "note folder not found" error message #2975

Closed
abraxas86 opened this issue Mar 1, 2024 · 7 comments
Closed
Labels
Milestone

Comments

@abraxas86
Copy link

Is your feature request related to a problem? Please describe.

When the application is unable to locate your notes folder, it throws the following message:

Your note folder was not found any more! Do you want to select a new one?

It never shows the old path, and I'm not sure if the path will be overwritten if I select "Yes" and give it a new location. The problem is that sometimes my drive orders get messed up due to removable media and cloud storage. If I could see what the path used to be, I'd be able to relocate it without issue.

Describe the solution you'd like

I'd like if the error message provided the former path, or gave the option to view the former path.

Describe alternatives you've considered

I can't really think of an alternative other than trying to figure out what file extension the application uses so I can dive into my storage locations to manually locate the files.

@pbek
Copy link
Owner

pbek commented Mar 1, 2024

QOwnNotes/src/main.cpp

Lines 261 to 265 in 56b949b

if (QMessageBox::question(nullptr, QObject::tr("Note folder not found!"),
QObject::tr("Your note folder was not found any more! Do you "
"want to select a new one?")) != QMessageBox::Yes) {
return false;
}

Sounds like a good, idea. Thank you.

@pbek pbek added Type: Feature adds functionality Importance: Medium and removed Type: Support labels Mar 1, 2024
@abraxas86
Copy link
Author

QOwnNotes/src/main.cpp

Lines 261 to 265 in 56b949b

if (QMessageBox::question(nullptr, QObject::tr("Note folder not found!"),
QObject::tr("Your note folder was not found any more! Do you "
"want to select a new one?")) != QMessageBox::Yes) {
return false;
}

Sounds like a good, idea. Thank you.

No, thank you! I was able to find my files in the end, I was smart when I made the folder (for once lmao).

I'll see what I can do to patch it in there. I suspect the harder part may be figuring out how to git properly 😅

I guess if I fork it, fix it, push it, and then create a pull request?

@pbek
Copy link
Owner

pbek commented Mar 2, 2024

Yes, you can 😉

pbek added a commit that referenced this issue Mar 7, 2024
@pbek
Copy link
Owner

pbek commented Mar 7, 2024

24.3.0

  • in the Note folder not found! dialog, the missing note folder path will now be shown

@pbek pbek added this to the 24.3.0 milestone Mar 7, 2024
@pbek
Copy link
Owner

pbek commented Mar 7, 2024

There now is a new release, could you please test it and report if it works for you?

@abraxas86
Copy link
Author

Worked like a charm! Thanks. Sorry for not doing it myself - been crazy busy with stuff at work trying to race a deadline. Once this storm has passed, I have some ideas on how we might be able to make that error even better. I won't be able to get started on that for another week or two, though.

@pbek
Copy link
Owner

pbek commented Mar 8, 2024

Great, thank you for testing!
No problem. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants