Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there any reason that there is no concrete version of math operation on, say DenseReal64Vector ? #9

Closed
keitamasuda opened this issue Nov 9, 2020 · 3 comments

Comments

@keitamasuda
Copy link

keitamasuda commented Nov 9, 2020

On the doc, it says

Methods, such as VaddV and MaddM, are generic and accept vector or matrix types that implement the respective ConstVector or ConstMatrix interface.
However, opertions on interface types are much slower than on concrete types, which is why most vector and matrix types in autodiff also implement methods that operate on concrete types.
For instance, DenseFloat64Vector implements a method called VADDV that takes as arguments two objects of type DenseFloat64Vector.
Methods that operate on concrete types are always named in capital letters.

But many types doesn't have the concrete version of the method. DenseReal64 is one of those type where it has MdotV but no MDOTV.

Is there any reason for this?

@pbenner
Copy link
Owner

pbenner commented Nov 9, 2020

You're right, there is no reason. I will add the missing methods.

@pbenner
Copy link
Owner

pbenner commented Nov 9, 2020

Done

@pbenner pbenner closed this as completed Nov 9, 2020
@keitamasuda
Copy link
Author

@pbenner
Thank you!
I thought there was a deep technical difficulty or design issue for this matter (that wasn't the case).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants